-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: User can select which apps can show shortcuts #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found only a few small things that could be discussed.
All in all: thx for this MR, i like this feature.
app/src/main/java/fr/neamar/kiss/loader/LoadShortcutsPojos.java
Outdated
Show resolved
Hide resolved
Would it make sense to hide both switches? Probably makes for a better UX :) Also, sorry, some conflicts were created recently, if you don't mind having a look! Overall, I like the idea too |
Thanks for the quick reviews guys. I'll have time to take a look and make changes on Sunday. Fingers crossed we can still be on time to make this feature someone's christmas present ;-) |
Agreed, will change this too |
# Conflicts: # app/src/main/java/fr/neamar/kiss/loader/LoadAppPojos.java
… shortcuts. Rework the exclude apps from shortcuts UI
Sorry for the delay getting back to this, but I've addressed all your comments now. Let me know what you think! |
@LukeNeedham @Neamar MR looks good to me 👍 |
Thanks for your contribution! |
@Neamar I saw a new release on Play Store with this feature not included. Does that mean Play Store users will have to wait months before they see this feature? |
Beta channel has the new feature already, On the other hand, production release was bumped out to v3.17 after weeks of testing and fixes. If you want the new feature already, join the beta channel and you'll get it now! |
Hi there, thanks for this great launcher. Been using it every day for the past 5 years and loving it! Thought it was time to give back ;-)
This is a use-case I personally have wanted for a while. In my case, I like having app shortcuts available in KISS for some apps, but not other apps. In particular, I've been wanting to get rid of the shortcuts from Spotify for a long time. This new feature makes that possible.
Resolved issues:
Possibly resolved issues:
The user can select which apps are allowed to display shortcuts using a new settings sub-page, using the existing
ExcludePreferenceScreen
. The excluded apps are stored in a StringSet in the SharedPreferences, in a similar way to how excluding apps from history works. Upon excluding / including an app, the shortcuts automatically refresh.Within 'Seach Settings', a new 'View or edit apps excluded from shortcuts' button has been added directly below the 'Shortcuts' switch. This button is added asynchronously:
Clicking that button brings you to this familiar UI:
Note that by default, no apps are excluded from showing shortcuts - not even KISS launcher itself.
The 'Shortcuts' switch still has ultimate power - if the switch is 'off', no shortcuts will show. If the switch is 'on', shortcuts will show for all the apps which aren't in the excluded list.
Tested on: